ISO images by default are uploaded as Raw/Thin Provision. And if you … #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrobonazzola
force-pushed
the
bugfix/upload-iso-as-preallocated
branch
from
6ed3a7e
to
65cd243
Compare
sandrobonazzola
requested changes
Oct 4, 2024
sermakov-orion
force-pushed
the
bugfix/upload-iso-as-preallocated
branch
from
65cd243
to
5885b92
Compare
|
@sandrobonazzola |
sandrobonazzola
approved these changes
Oct 4, 2024
sandrobonazzola
requested review from
sandrobonazzola
and removed request for
sgratch
dupondje
suggested changes
Oct 16, 2024
| VolumeFormat.COW : getImageInfoModel().getFormat(); | ||
| diskImage.setVolumeFormat(volumeFormat); | ||
| DiskContentType contentType = getImageInfoModel().getContentType(); | ||
| if (volumeFormat != VolumeFormat.COW && contentType == DiskContentType.ISO) { |
There was a problem hiding this comment.
I think we can just add the additional if:
if (diskImage.getVolumeFormat() != VolumeFormat.COW && getImageInfoModel().getContentType() == DiskContentType.ISO) {
diskImage.setVolumeType(VolumeType.Preallocated);
}
And skip the other changes :)
There was a problem hiding this comment.
@dupondje Thanks for the suggestion.
I applied the changes (with additional comments).
Could you please review once more?
Thanks in advance.
…later move such disk to a block storage (FC/iSCSI) then it will be converted to Cow/Thin Provision. And this might corrupt the disk. To avoid this issue we suggested to always upload ISO images as Raw/Preallocated. In this case no conversion needed while moving to a block storage. And disk works fine in both types (block and non-block) storages. Signed-off-by: Stepan Ermakov <sermakov@orionsoft.ru>
sermakov-orion
force-pushed
the
bugfix/upload-iso-as-preallocated
branch
from
5885b92
to
75c88cf
Compare
dupondje
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO images by default are uploaded as Raw/Thin Provision. And if you later move such disk to a block storage (FC/iSCSI) then it will be converted to Cow/Thin Provision. And this might corrupt the disk. To avoid this issue we suggested to always upload ISO images as Raw/Preallocated. In this case no conversion needed while moving to a block storage. And disk works fine in both types (block and non-block) storages.
Are you the owner of the code you are sending in, or do you have permission of the owner?
y