drop remaining netaddr #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit fd20e99 dropped python-netaddr dependency, remove remaining usage of filters requiring it Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
michalskrivanek
force-pushed
the
netaddr2
branch
from
1998fdb
to
a4f4e9b
Compare
michalskrivanek
force-pushed
the
netaddr2
branch
from
f2693cd
to
a4f4e9b
Compare
Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
michalskrivanek
force-pushed
the
netaddr2
branch
from
7fe2512
to
3eb88eb
Compare
not nice, but there are just too many.... Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
|
/ost he-basic-suite-master |
2 similar comments
|
/ost he-basic-suite-master |
|
/ost he-basic-suite-master |
|
fix works. however test_upload_cirros_image is screwed up both on el8 and el9 but I believe that's a different issue |
mnecas
requested changes
Apr 17, 2023
| @@ -49,7 +52,7 @@ jobs: | |||
| "ansible-lint>=6.0.0,<7.0.0" \ | |||
| cryptography \ | |||
| "pyyaml>=5.4.1" | |||
| ansible-lint roles/* -x 204 | |||
| ansible-lint -x 'key-order[task],no-free-form,schema[vars],yaml[octal-values],risky-shell-pipe,fqcn[keyword]' roles/*roles/* | |||
There was a problem hiding this comment.
Think you have typo in roles/*roles/* should be roles/*
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit fd20e99 dropped python-netaddr
dependency, remove remaining usage of filters requiring it