Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles: hosted_engine_setup: align with ansible-lint 5.0.0 #271

Merged
merged 6 commits into from
May 12, 2021
Merged

roles: hosted_engine_setup: align with ansible-lint 5.0.0 #271

merged 6 commits into from
May 12, 2021

Conversation

arachmani
Copy link
Member

Fixes #266

Signed-off-by: Asaf Rachmani arachman@localhost.localdomain

@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
c40f669 
Fixes oVirt#266

Signed-off-by: Asaf Rachmani <arachman@localhost.localdomain>
@mnecas
Copy link
Member

mnecas commented May 6, 2021

I'm not sure about the usage of the debug module in the role but you don't need to remove all just need to add a name for that task.

There are still a few errors around load-failure

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/add_engine_as_ansible_host.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/add_engine_as_ansible_host.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/alter_libvirt_default_net_configuration.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/alter_libvirt_default_net_configuration.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/apply_openscap_profile.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/apply_openscap_profile.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/auth_revoke.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/auth_revoke.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/auth_sso.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/auth_sso.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/clean_local_storage_pools.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/clean_local_storage_pools.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/clean_localvm_dir.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/clean_localvm_dir.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/get_local_vm_disk_path.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/get_local_vm_disk_path.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/install_appliance.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/install_appliance.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/pause_execution.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/pause_execution.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/restore_backup.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/restore_backup.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/bootstrap_local_vm/validate_ip_prefix.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/validate_ip_prefix.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/create_target_vm/add_engine_as_ansible_host.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/create_target_vm/add_engine_as_ansible_host.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/create_target_vm/auth_sso.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/create_target_vm/auth_sso.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/create_target_vm/get_local_vm_disk_path.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/create_target_vm/get_local_vm_disk_path.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/create_target_vm/ipv_switch.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/create_target_vm/ipv_switch.yml:0

load-failure: [Errno 2] No such file or directory: 'roles/hosted_engine_setup/tasks/pre_checks/filter_unsupported_devices.yml' (filenotfounderror)
roles/hosted_engine_setup/tasks/pre_checks/filter_unsupported_devices.yml:0

@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
d3c8e9f 
Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani
Copy link
Member Author

I'm not sure about the usage of the debug module in the role but you don't need to remove all just need to add a name for that task.

We don't really need it, we can use the log files or verbose mode to check the value of these vars.

@arachmani arachmani changed the title roles: hosted_engine_setup: align with ansible-lint 5.0.0 [WIP] roles: hosted_engine_setup: align with ansible-lint 5.0.0 May 6, 2021
@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
7fb179f 
Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
e0ab56f 
Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani arachmani changed the title [WIP] roles: hosted_engine_setup: align with ansible-lint 5.0.0 roles: hosted_engine_setup: align with ansible-lint 5.0.0 May 6, 2021
@arachmani arachmani requested a review from mnecas May 6, 2021 11:19
mnecas
mnecas approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arachmani
Copy link
Member Author

Verified

@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
dcd00da 
Add changelogs

Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0
03bf19a 
Add newline at end of the changelog file

Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani arachmani mentioned this pull request May 11, 2021
Merged
@mnecas
Copy link
Member

mnecas commented May 11, 2021

ci test please

@mnecas mnecas merged commit b506a12 into oVirt:master May 12, 2021
arachmani added a commit to arachmani/ovirt-ansible-collection that referenced this pull request May 12, 2021
@arachmani
roles: hosted_engine_setup: align with ansible-lint 5.0.0 (oVirt#271)
25283eb 
* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fixes oVirt#266

Signed-off-by: Asaf Rachmani <arachman@localhost.localdomain>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add changelogs

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add newline at end of the changelog file

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

Co-authored-by: Asaf Rachmani <arachman@localhost.localdomain>
mnecas pushed a commit to mnecas/ovirt-ansible-collection that referenced this pull request May 14, 2021
@arachmani @mnecas
roles: hosted_engine_setup: align with ansible-lint 5.0.0 (oVirt#271)
6b02bc4 
* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fixes oVirt#266

Signed-off-by: Asaf Rachmani <arachman@localhost.localdomain>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add changelogs

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add newline at end of the changelog file

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

Co-authored-by: Asaf Rachmani <arachman@localhost.localdomain>
vjuranek pushed a commit to vjuranek/ovirt-ansible-collection that referenced this pull request Jul 28, 2021
@arachmani @vjuranek
roles: hosted_engine_setup: align with ansible-lint 5.0.0 (oVirt#271)
068bc4f 
* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fixes oVirt#266

Signed-off-by: Asaf Rachmani <arachman@localhost.localdomain>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Fix "load-failure: [Errno 2]" errors

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add changelogs

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* roles: hosted_engine_setup: align with ansible-lint 5.0.0

Add newline at end of the changelog file

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

Co-authored-by: Asaf Rachmani <arachman@localhost.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnecas mnecas mnecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ansible-lint 5.0.0 for hosted_engine_setup
2 participants
@arachmani @mnecas