Merge pull request #19 from o1egl/test_os_matrix

o1egl · Mar 14, 2021 · 8eef4de · 8eef4de
2 parents a3044b1 + 51019ae
commit 8eef4de
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -22,16 +22,20 @@ jobs:
           version: v1.37.1
           skip-go-installation: true
   test:
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
           go-version: 1.16
       - name: Test
-        run: go test -race -timeout=60s -v -coverprofile=coverage.txt -covermode=atomic ./...
+        run: go test -race -timeout=60s -v -coverprofile="coverage.txt" -covermode=atomic ./...
       - uses: codecov/codecov-action@v1
+        if: ${{ matrix.os == 'ubuntu-latest' }}
         with:
           file: ./coverage.txt
   release:

diff --git a/govatar.go b/govatar.go
@@ -13,6 +13,7 @@ import (
 	"io/fs"
 	"math/rand"
 	"os"
+	"path"
 	"path/filepath"
 	"sort"
 	"strings"
@@ -175,7 +176,7 @@ func mustAssetsList(dir string) []string {
 	}
 	assets := make([]string, len(dirEntries))
 	for i, dirEntry := range dirEntries {
-		assets[i] = filepath.Join(dir, dirEntry.Name())
+		assets[i] = path.Join(dir, dirEntry.Name())
 	}
 	sort.Sort(naturalSort(assets))
 	return assets