Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Saffron in it's own workflow, restore OG CI for core lib only #3035

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Feb 13, 2025

This actually fixes the problem that #3023 failed to address.

  • Run all saffron unit tests in their own workflow
  • Stop running saffron in the general CI workflow

Post Mortem

The tests themselves weren't even the problem -- there were 2 other major factors:

  • The code coverage job was building everything with instrumentation flags that were causing something like a 100x slowdown 🤯
  • Since the tests were being run without the SRS cache, they were spending a lot of time computing one (likely once per test module)

@martyall martyall marked this pull request as ready for review February 13, 2025 20:03
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (1569ce6) to head (a40d707).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3035      +/-   ##
==========================================
+ Coverage   76.89%   77.23%   +0.34%     
==========================================
  Files         262      254       -8     
  Lines       62118    61044    -1074     
==========================================
- Hits        47763    47150     -613     
+ Misses      14355    13894     -461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -96,24 +96,24 @@ test-all-with-coverage:


nextest: ## Test the project with non-heavy tests and using nextest test runner
cargo nextest run --all-features --release --profile ci -E "not test(heavy)" $(BIN_EXTRA_ARGS)
cargo nextest run --all-features --release $(CARGO_EXTRA_ARGS) --profile ci -E "not test(heavy)" $(BIN_EXTRA_ARGS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked it was not running the Saffron tests.

@dannywillems dannywillems merged commit 91ee806 into master Feb 13, 2025
13 checks passed
@dannywillems dannywillems deleted the martin/saffron-disable-codecoverage branch February 13, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants