Skip to content

Commit

Permalink
Marc's PR comments: adjust some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
martyall committed Jan 30, 2025
1 parent 35a9470 commit 97ee9f7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions saffron/src/proof.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ where
let evaluation = p.evaluate(&evaluation_point);
let opening_proof_sponge = {
let mut sponge = EFqSponge::new(G::other_curve_sponge_params());
// TODO: check and see if we need to also absorb the absorb the poly cm
// see https://github.com/o1-labs/proof-systems/blob/feature/test-data-storage-commitments/data-storage/src/main.rs#L265-L269
sponge.absorb_fr(&[evaluation]);
sponge
};
Expand All @@ -58,8 +60,8 @@ where
},
)],
&[evaluation_point],
G::ScalarField::one(), // Single polynomial, so we don't care
G::ScalarField::one(), // Single polynomial, so we don't care
G::ScalarField::one(), // Single evaluation, so we don't care
G::ScalarField::one(), // Single evaluation, so we don't care
opening_proof_sponge,
rng,
);
Expand Down

0 comments on commit 97ee9f7

Please sign in to comment.