Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kubeconfig context name generation for regional use (0.8.x) #95

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

montmanu
Copy link
Contributor

the recent changes to support regional clusters did not include updates to the kubeconfig context name generation logic.. some sample results of the current issue when used with the regional parameter:

kubectl config set-context gke_my-project__my-cluster --namespace qa
# Context "gke_my-project__my-cluster" created.

the namespace resource is successfully created, and if you explicitly configure the namespace of resources within your templates, those resources will be configured properly, but for users that do not explicitly configure the namespace within their templates (relying on the context instead), their resources will end up applied, but to the default namespace.

@montmanu
Copy link
Contributor Author

an alternative approach might be to implement the equivalent of

kubectl config set-context $(kubectl config current-context) --namespace foo

@yunzhu-li yunzhu-li requested a review from tonglil July 12, 2018 15:13
Copy link
Member

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @montmanu!

@tonglil tonglil merged commit 57c5e00 into nytimes:master Jul 12, 2018
@montmanu montmanu deleted the 0.8.x/regional-clusters-ns-fix branch July 12, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants