Support an existing 'events' function attribute #51
+123
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stickit binds to form and contentEditable element changes by adding bindings to a view's 'events' attribute, which may already exist on the view. This commit updates stickit() to support an existing 'events' attribute that is specified as a function, which is already allowed by Backbone.
delambo
added a commit
that referenced
this pull request
Jan 18, 2013
|
Good stuff. Thanks, Matt! |
trabianmatt
pushed a commit
to trabianmatt/backbone.stickit
that referenced
this pull request
Jan 19, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I occasionally define 'events' as a method on a view (instead of a hash):
Backbone supports this but when I tried to use stickit to bind to a form field the field events were never added to 'events' because 'events' was a function and not a hash. This pull requests adds support for an 'events' function. I added tests for this new case as well as the 'events as hash' case.
Thank you for stickit - I'm looking forward to using it more and contributing where I can!