Allow binding <select>s via data attributes #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akre54 would you mind taking another look at this one? Thank you for your feedback yesterday! |
| binding = binding || {}; | ||
| namespace = '.stickit.' + model.cid; | ||
|
|
||
| binding = binding || {}; |
|
Minor nits but otherwise looks good. Thanks! |
|
Squash down to one commit and I'll merge. Thanks again |
|
@akre54 many thanks for reviewing this PR! Just fixed those last issues + squashed it down! |
|
Actually -- my apologies, want to squash in one last change (simply changing |
|
(updated that and Travis seems happy about it) |
akre54
added a commit
that referenced
this pull request
Oct 22, 2014
…a_attributes Allow binding <select>s via data attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve #249 by allowing pre-rendered
<select><option>s to have values bound from a data attribute (data-stickit-bind-val, which was previously used only internally and nameddata-stickit_bind_val), rather than from the<option value>.The tests now verify that pre-rendered
<select>s withoutdata-stickit-bind-valcontinue to have their options processed to a collection containing string values, and that ones withdata-stickit-bind-valnow support numeric values.This fixes a longstanding issue with binding pre-rendered selects at the cost of some extra complexity and a bit of duplicative markup.