chore: don't rederive wallet keys on every tx #6213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstruction Previously all the keys and account information was being derived for every transaction signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
jstuczyn
force-pushed
the
chore/dont-rederive-wallet
branch
from
67fefba to
0a30538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change I've been meaning to do for a while now. the cosmrs' trait bounds on
EcdsaSignergot updated to includeSendandSync, meaning we no longer need to derive private keys on every transaction and instead we can just do it once, on construction.note that I had to deprecate some builder methods as they're no longer safe (i.e. they can possibly panic). They were not removed so it wouldn't break compatibility with the library consumers (looking at VPN-core)
This change is