Add weighted scoring to NS API #6144
Draft
+159
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
benedettadavico
modified the milestones:
Leerdammer (est. mainnet 11.11.2025),
Mozzarella (est. mainnet 25.11.2025),
Temporary Home
benedettadavico
force-pushed
the
ns/weighted-scoring
branch
from
eb2df3e to
90e07d9
Compare
jstuczyn
reviewed
Nov 20, 2025
| (file_download_score, ping_ips_performance) | ||
| }) | ||
| .unwrap_or(0f64); | ||
| .unwrap_or((0.0, 0.0)); |
Contributor
There was a problem hiding this comment.
I'd say define a helper struct, like
struct NodeScore {
download_speed_score: f64,
ping_ips_score: f64
}rather than passing an (f64, f64) tuple, because somebody, at some point, will accidentally mix them up
Contributor
There was a problem hiding this comment.
or maybe you could even include there mixnet_performance and have fn calculate_weighted_score(&self) -> f64 so that it would be slightly more maintainable and easier to adjust the inidividual weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is