socks5: wait to close buffer #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
requested review from
durch,
futurechimp,
jstuczyn and
neacsu
as code owners
octol
force-pushed
the
fix/socks5/wait-close-buffer-until-end
branch
from
c4bb581
to
1b9ab82
Compare
jstuczyn
reviewed
Oct 24, 2022
|
I was playing around with this patch for some casual keybase use and I didn't spot any situations where the new logic closed the connection earlier than the old logic, but I did spot some cases (very few, but indeed happening) where the new logic closes the connection slightly later then before |
octol
force-pushed
the
fix/socks5/wait-close-buffer-until-end
branch
from
6716715
to
d1805bb
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #1960
Closes: #1701
This is the fix proposed by @simonwicky in #1701
Checklist:
CHANGELOG.md