client: allow rerun init for gateway config #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
requested review from
mfahampshire,
durch,
futurechimp,
jstuczyn and
neacsu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2017
Currently re-running init fails for the native and socks5 client. The gateway registration is skipped, but that also means the gateway related fields in the config is never set so when the config file is written the previously set gateway fields are erased.
This PR changes so that rerunning init will reuse the gateway config fields, and adds another flag
--force-register-gatewaythat will trigger gateway registration regardless if the config file and associated keys already exists or not.Checklist:
CHANGELOG.md