Skip to content

Conversation

jmwample
Copy link
Contributor

@jmwample jmwample commented Jul 14, 2025

Apply fix from hyperium/h2#847 so that hickory-dns DoH connections consider server go_away close as valid and don't spam warning logs.

This is done in conjunction with the same change in the core (nymtech/nym#5893).


This change is Reviewable

@jmwample jmwample requested a review from pronebird July 14, 2025 16:20
Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmwample)

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmwample)

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to consider dropping a note innym-vpn-core/CHANGELOG.md under unreleased section

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmwample)

@jmwample jmwample merged commit 26abac4 into develop Jul 14, 2025
19 checks passed
@jmwample jmwample deleted the jmwample/h2-dep branch July 14, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants