-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage #5
Coverage #5
Conversation
"unused": true, | ||
"strict": true, | ||
"node": true, | ||
"latedef": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because comments are not valid json, and a jsonlinter gets angry at it. Don't you have a jsonlinter in sublime? :p
Also, all the comments were doing is repeating what the setting was. Writing 2, and then two again in longer English, isn't really what comments are for. If they were saying why it's 2, then I'd be much more interested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but a .jshintrc technically isn't json.
I agree that "how" comments are bad and wrong, but some of them are "why" comments. Also, I really like knowing what eqeqeq
and newcap
do without having to look them up every. single. time.
(this is especially important with jshint, since half the rules are positive (allow these things) and half the rules are negative (ban these other things).
Changes Unknown when pulling 36ce898 on coverage into * on master*. |
Unknown, eh? That's pretty spooky. |
That is spooky. At least its reporting coverage correctly. I'll add back the comments. Maybe someday they'll allow yaml. |
Now I have this stuck in my head, thanks. |
Changes Unknown when pulling ab2ef3d on coverage into * on master*. |
Add coverage reporting.