Enable SDK to reattach large files to messages on retry#487
Merged
mrashed-dev merged 7 commits intomainfrom Sep 23, 2024
Merged
Conversation
if the file path is present and the file is closed, we can make a copy of the payload and try to re-open the file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 99.85% 99.14% -0.72%
==========================================
Files 24 24
Lines 681 700 +19
==========================================
+ Hits 680 694 +14
- Misses 1 6 +5 ☔ View full report in Codecov by Sentry. |
…-send-does-not-include-attachments
Merged
mrashed-dev
added a commit
that referenced
this pull request
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the SDK to re-attach large files when trying to retry the same request body. If a
file_pathis provided with the attachment request and the file stream is closed, the SDK will attempt to reopen it. The helper functionattach_file_request_builderwill now set thefile_pathin the object, so if you're currently using that helper function, the attachment will be ready for reattachment.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.