fix: ListThreadsQueryParams.inFolder now correctly uses single folder ID#280
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=========================================
Coverage 80.57% 80.57%
Complexity 333 333
=========================================
Files 36 36
Lines 1014 1014
Branches 88 88
=========================================
Hits 817 817
Misses 138 138
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The Nylas API only supports filtering by a single folder ID, but the SDK was incorrectly accepting a List<String> and sending all items to the API. The API would only use the last item, causing unexpected behavior. Changes: - Modified ListThreadsQueryParams.convertToMap() to use only the first folder ID from a list, matching API behavior - Added new inFolder(String) method in Builder (recommended approach) - Deprecated inFolder(List<String>) method with clear migration guidance - Added comprehensive test coverage for all scenarios - Updated documentation with API limitations and usage examples - Maintained full backward compatibility The fix ensures proper API behavior while providing a clear migration path for users. In the next major version, the parameter will be changed to accept only a String. Fixes issue where only the last folder ID was used when multiple folder IDs were provided in the inFolder parameter.
3891404 to
c9897db
Compare
pooja169usp
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you do?
The Nylas API only supports filtering by a single folder ID, but the SDK
was incorrectly accepting a List and sending all items to the API.
The API would only use the last item, causing unexpected behavior.
Changes:
folder ID from a list, matching API behavior
The fix ensures proper API behavior while providing a clear migration
path for users. In the next major version, the parameter will be
changed to accept only a String.
Fixes issue where only the last folder ID was used when multiple
folder IDs were provided in the inFolder parameter.
📋 Usage Examples
New recommended approach:
Deprecated but still working:
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.