fix(request): default QUERY to idempotent#48
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Undici’s core Request construction so the RFC 10008 QUERY method is treated as idempotent by default (like GET/HEAD), enabling HTTP/1.1 pipelining unless the caller explicitly sets idempotent: false.
Changes:
- Default
Request#idempotenttotrueformethod: 'QUERY'whenidempotentis not provided. - Add client-level tests proving
QUERYpipelines by default, and remains queued when explicitly overridden withidempotent: false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/client-query-idempotence.js | Adds coverage for default pipelining behavior of QUERY vs. explicit idempotent: false queuing. |
| lib/core/request.js | Extends default idempotency detection to include QUERY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ronag
force-pushed
the
codex/default-query-idempotent
branch
from
July 11, 2026 18:40
0485eb0 to
c5d3d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QUERYidempotent by default alongsideGETandHEADidempotent: falseoverrideRebased onto current
masterafter the Blob metadata and header snapshot hardening landed.Validation
git diff --checkpassed