Open
Conversation
Member
Author
|
@jasnell ping |
ronag
commented
Jun 16, 2020
| this.emit('ready'); | ||
| // TODO (fix): What happens on failure? We still need to | ||
| // invoke the callback somehow? Change signature of kSetHandle | ||
| // to (err, handle)? |
There was a problem hiding this comment.
Possibly. The failure conditions have not been fully tested yet.
jasnell
reviewed
Jun 16, 2020
| // internal handle has been created. The QuicStream object | ||
| // is still minimally usable before this but any data | ||
| // written will be buffered until kSetHandle is called. | ||
| this[kSetHandle] = (handle) => { |
There was a problem hiding this comment.
I really dislike the property pattern for these functions. I'd rather [kSetHandle] be a function on the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes