-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreal Engine 5 compatibility update #248
base: master
Are you sure you want to change the base?
Unreal Engine 5 compatibility update #248
Conversation
Thanks. I'll check it. |
|
Yeah, that sounds right. I believe they made it generic for the large world coordinates. I'm not sure if this will change back to a specific type with 5.0 stable. Reading the codebase, I saw there was mention that floats will become doubles in 5.0 to support large world coordinates. |
Will it work with preview2 as well? |
Yeah, I think there's been a few changes with these classes. Haven't yet tried to port to Preview 2, but on my task list for the week so can feedback here! |
Changing the |
There are a bunch of other methods that require refactoring for double precision. It seems that I have to make a separate branch for UE5 and maintain it along with master or drop support of UE4 entirely. 🙄 |
Consider using "#if" solutions instead of maintaining different branches. |
Cool stuff... Any idea on a timeframe for when a UE5 compatible version will be ready for download? Or is there a test branch I can download now? |
Nice! Any news regarding UE5 support? |
That's probably an acceptable way to solve it, but I have no clue what to do with the double-precision math since it's not supported yet in |
This PR contains the start of a migration to UE5 Preview. I struggled to find a way to get a macro that associates UE5 with Preview instead of Early Access. Closest I could find was the BRANCH_NAME macro. Maybe @nxrighthere you know of a better way? I guess once UE5 stable is out Early Access won't need to be supported.
There is also a deprecated warning for UObject->IsPendingKill function. I've left that out for now, I imagine if it is being deprecated we could just omit it in UE5.
Hope this helps!