Skip to content

deps: update #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

deps: update #226

wants to merge 1 commit into from

Conversation

ParkerOu
Copy link

@ParkerOu ParkerOu commented Jun 22, 2024

Due to package deprecation, it has been replaced with a new package

  1. vue-cli -> vite
  2. xterm-addon-fit -> @xterm/addon-fit
  3. xterm -> @xterm/xterm

After the update, four moderate-severity vulnerabilities were fixed.

@ParkerOu
Copy link
Author

If it's set up on a non-root path, such as https://my-domain/piping-ssh-web, you need to modify vite.config.mjs by adding base: '/piping-ssh-web/' to the defineConfig()

import { fileURLToPath, URL } from 'node:url';
import { defineConfig } from 'vite';
import vue from '@vitejs/plugin-vue';
import { createHtmlPlugin } from 'vite-plugin-html';

export default defineConfig({
  base: '/piping-ssh-web/', // add this line if needed
  plugins: [
    vue(),
    createHtmlPlugin({
      minify: true,
      inject: {
        data: {
          title: 'Piping SSH',
        },
      },
    }),
  ],
  esbuild: {
    target: 'es2015',
  },
  resolve: {
    alias: {
      '@': fileURLToPath(new URL('./src', import.meta.url)),
    },
  },
});

@ParkerOu
Copy link
Author

@nwtgck Could you help me check if the PR is OK?

@nwtgck
Copy link
Owner

nwtgck commented Mar 29, 2025

@ParkerOu
Thank you for your pull request to update the dependencies! I appreciate your efforts to address package deprecation and security fixes. However, as the project maintainer, I feel it's important that I handle changes to the core dependencies and infrastructure myself. This allows me to thoroughly review the impact of the changes, ensure compatibility, and maintain the overall integrity of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants