-
Notifications
You must be signed in to change notification settings - Fork 3.9k
add isDevToolsOpen #8063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isDevToolsOpen #8063
Conversation
so, when i run
it returns
|
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Please fix the documentation as well. |
no need to update nw_api_window.js ... |
@jonlepage please remove mention of isDevToolsOpen from the known issues also if you could add in example usage here such as |
Sorry, I don't understand. I don't see any trace of JSDoc for the documentation, and if you are referring to TypeScript documentation, it should be edited at https://github.com/DefinitelyTyped/DefinitelyTyped |
https://github.com/nwjs/nw.js/blob/nw91/docs/For%20Users/Migration/From%200.12%20to%200.13.md @jonlepage sorry should have linked the Markdown docs |
@@ -59,7 +59,7 @@ | |||
### Known issues | |||
|
|||
+ The following window options passed to `nw.Window.open()` is not effective on **Linux**: `resizable` for now; try to set them in the callback. | |||
+ `reloadDev()` and `isDevToolsOpen()` of `nw.Window` are not supported for now | |||
+ `reloadDev()` of `nw.Window` are not supported for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ `reloadDev()` of `nw.Window` are not supported for now | |
+ `reloadDev()` of `nw.Window` is not supported for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit and should be good to go
@rogerwang this looks good to me, let us know if any other changes are required |
fix: #4487