enable midi -> audio (efficiently) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SORRY! I meant to approve the workflow to allow the tests to run. I did not mean to approve and merge the entire PR. Given that the tests fail, I have reverted this merge. https://github.com/nwhitehead/pyfluidsynth/actions/runs/12204520027 Can you please recreate this pull request to make up for my mistake? Thanks! |
cclauss
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need to synthesize a large number of audio files from midi using fluidsynth. However, pyfluidsynth haven't implemented this.
In the Python library 'midi2audio', the author fulfilled "audio file synthesis" using the command-line function of fluidsynth. However, a large amount of time is required for one execution, and I find that it is creating the synth (along with loading soundfont) that takes up the majority of the time. So I digged into the source code and now pyfluidsynth can synthesize lots of midi files with only one load, greatly accelerating the process.
test7.py shows how to use the new function.