Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621: Migrate from setup.py to pyproject.toml #76

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Oct 20, 2024

How

Migrate setup.py to setup.cfg using setuptools-py2cfg plus manual modifications. Then migrate settings from setup.cfg into pyproject.toml using ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject to validate the results.

git checkout -b setuptools-py2cfg
pipx run setuptools-py2cfg > setup.cfg
pipx run ini2toml setup.cfg -o pyproject.toml
git add pyproject.toml
pipx run validate-pyproject pyproject.toml
code pyproject.toml  # Make any suggested changes
pipx run pyproject-fmt pyproject.toml
pipx run validate-pyproject pyproject.toml
git rm --force setup.cfg
git rm setup.py
code makefile .github/workflows/pythonpublish.yml
python3 -m venv venv
source venv/bin/activate
python -m pip install --upgrade pip
pipx run build  # —> Successfully built pyfluidsynth-1.3.4.tar.gz and pyfluidsynth-1.3.4-py3-none-any.wh
ls dist  # —> pyfluidsynth-1.3.4-py3-none-any.whl pyfluidsynth-1.3.4.tar.gz
python -m pip install --editable .
git commit -am"PEP 621: Migrate from setup.py to pyproject.toml"
git push

Why

https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use

We recommend users expose as much as possible configuration in a more declarative way via the pyproject.toml or setup.cfg, and keep the setup.py minimal with only the dynamic parts (or even omit it completely if applicable).

From validate-pyproject README:

With the approval of PEP 517 and PEP 518, the Python community shifted towards a strong focus on standardization for packaging software, which allows more freedom when choosing tools during development and make sure packages created using different technologies can interoperate without the need for custom installation procedures.

This shift became even more clear when PEP 621 was also approved, as a standardized way of specifying project metadata and dependencies.

validate-pyproject was born in this context, with the mission of validating pyproject.toml files, and making sure they are compliant with the standards and PEPs.

@cclauss cclauss requested a review from nwhitehead October 20, 2024 10:02
@cclauss cclauss merged commit eea3abb into nwhitehead:master Oct 25, 2024
5 checks passed
@cclauss cclauss deleted the setup.py-to-pyproject.toml branch October 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant