Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndx-depth-moseq #46

Merged
merged 11 commits into from
Jul 25, 2024
Merged

ndx-depth-moseq #46

merged 11 commits into from
Jul 25, 2024

Conversation

pauladkisson
Copy link
Contributor

This extension currently adds a neurodata type for depth moseq's extract step.

@rly
Copy link
Contributor

rly commented Dec 12, 2023

Hi @pauladkisson, this PR adds two extensions -- did you mean to include ndx-bipolar-referencing?

@pauladkisson
Copy link
Contributor Author

Hi @pauladkisson, this PR adds two extensions -- did you mean to include ndx-bipolar-referencing?

Not sure why this extension snuck into Master on the catalyst neuro side but I just removed it.

@rly
Copy link
Contributor

rly commented Dec 14, 2023

Sounds good. Please mark as ready for review when ready and I'll take a look.

@pauladkisson pauladkisson marked this pull request as ready for review December 15, 2023 01:02
ndx-depth-moseq/ndx-meta.yaml Outdated Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Jul 25, 2024

Looks good to me, pending a version update. Sorry I missed this after your last comment!

Co-authored-by: Ryan Ly <rly@lbl.gov>
@pauladkisson
Copy link
Contributor Author

Looks good to me, pending a version update. Sorry I missed this after your last comment!

Done!

@rly rly merged commit d1447e8 into nwb-extensions:main Jul 25, 2024
@rly rly deleted the ndx-depth-moseq branch July 25, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants