Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat/redisign the Docker image creation. #1

Merged
merged 8 commits into from
Jan 5, 2024

Conversation

plague-doctor
Copy link
Contributor

@plague-doctor plague-doctor commented Dec 28, 2023

Thanks for your work! This is exactly what I was searching for.

A few changes to your dockerisation of BounCA:

Changes to Dockerfile:

  • Prepare the building for automation. (Still waiting for https://gitlab.com/gitlab-org/gitlab/-/issues/421976 to be able to get the latest package).
  • Reformat layers to save some space on the image (FYI: every RUN creates a new layer. If in one later you pull a file and in another layer you delete it, this doesn't change the size of the final image. Do all such operations within the same layer). This reformat saves almost 100MB in image size.

Changes to bounca-config.sh:

  • Wait for Postgres to become available instead of quitting bounca when it is not available.
  • Create Django Superuser when DJANGO_SUPERUSER_PASSWORD is specified.
  • Rename/unify variables.

@nvollmar
Copy link
Owner

nvollmar commented Jan 1, 2024

Thank you for the contribution. I'll review and merge it once I'm back home.

Copy link
Owner

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for the improvements

@nvollmar nvollmar merged commit 6e70566 into nvollmar:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants