Repository navigation
feat: allow npm flags (e.g. --install-links) in default-packages file - #3922
Draft
ousamabenyounes wants to merge 1 commit into
Draft
ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
Member
|
This PR was premature; the issue does not have "help wanted" and it's not certain it's even a feature I want to have. |
ljharb
marked this pull request as draft
September 11, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvm_get_default_packages now permits npm flags (tokens starting with -) alongside a package on a line, or on their own line, instead of rejecting any line containing whitespace. Lines with 2+ actual packages are still rejected. Fixes #3866.
Test verification (RED → GREEN)
With the fix reverted, the new test fails (RED):
With the fix applied, the test passes (GREEN):
Full local suite
Command:
npm run test/fastFix #3866