Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove backslash to avoid alias from source (\. nvm.sh) on README.md #2626

Closed
wants to merge 1 commit into from

Conversation

umireon
Copy link
Contributor

@umireon umireon commented Oct 6, 2021

alias .=something won't happen and we must consider alias export=something if we assume this happens.
\. is also confusing because it is different from the ordinary way.

`alias .=something` won't happen and we must consider `alias export=something` if we assume this happens.
`\.` is also confusing because it is different from the ordinary way.
@ljharb
Copy link
Member

ljharb commented Oct 6, 2021

It absolutely will happen, and did, which is why we added the backslash - see #1701 (comment).

@ljharb ljharb added the non-issue / invalid This isn't relevant to nvm, or turned out to be something unrelated. label Oct 6, 2021
@ljharb ljharb closed this Oct 6, 2021
@ljharb
Copy link
Member

ljharb commented Oct 6, 2021

In the future, please discuss PRs in an issue before filing them.

@umireon umireon changed the title Remove backslash from sourcing on README.md Remove backslash from sourcing (. nvm.sh) on README.md Oct 6, 2021
@umireon umireon changed the title Remove backslash from sourcing (. nvm.sh) on README.md [Docs] Remove backslash to avoid alias from source (. nvm.sh) on README.md Oct 6, 2021
@umireon umireon changed the title [Docs] Remove backslash to avoid alias from source (. nvm.sh) on README.md [Docs] Remove backslash to avoid alias from source (\. nvm.sh) on README.md Oct 6, 2021
@umireon
Copy link
Contributor Author

umireon commented Oct 6, 2021

Oof, my searching on GitHub didn't work, Only what I found was a commit without description on git blame 4 years ago.
I've changed the name of this PR for searchability.

@umireon
Copy link
Contributor Author

umireon commented Oct 6, 2021

Oh, I can track the related PR from a commit on GitHub, I didn't know this.
スクリーンショット 2021-10-07 4 32 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue / invalid This isn't relevant to nvm, or turned out to be something unrelated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants