Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix manual install & upgrade guide #1786

Merged

Conversation

PeterDaveHello
Copy link
Collaborator

@joshsleeper
Copy link
Contributor

joshsleeper commented Apr 12, 2018

I don't know enough about git describe and git rev-list to know if this is an appropriate use of these commands, but I do know that it seems to work as expected (assuming that's the expected response)

[USER@HOSTNAME .nvm]$ git checkout `git describe --abbrev=0 --tags --match "v[0-9]*" $(git rev-list --tags --max-count=1)`
HEAD is now at 7ad6d98... v0.33.8

more testing, this time manually checking out the v0.33.7 tag and then using the upgrade checkout command to verify it moved me to v0.33.8, which it did!

[USER@HOSTNAME .nvm]$ git checkout `git describe --abbrev=0 --tags --match "v0.33.7" $(git rev-list --tags --max-count=1)`
Previous HEAD position was 7ad6d98... v0.33.8
HEAD is now at 65f0572... v0.33.7
[USER@HOSTNAME .nvm]$ git checkout `git describe --abbrev=0 --tags --match "v[0-9]*" $(git rev-list --tags --max-count=1)`
Previous HEAD position was 65f0572... v0.33.7
HEAD is now at 7ad6d98... v0.33.8

@ljharb ljharb force-pushed the fix-manual-install-upgrade-guide branch from ccc6cf5 to 8ff437a Compare April 12, 2018 20:33
@ljharb ljharb added informational installing nvm Problems installing nvm itself labels Apr 12, 2018
@ljharb ljharb merged commit 8ff437a into nvm-sh:master Apr 12, 2018
@PeterDaveHello PeterDaveHello deleted the fix-manual-install-upgrade-guide branch April 13, 2018 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing nvm Problems installing nvm itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants