-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #1756
Spelling #1756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -13,7 +13,7 @@ die () { echo "$@" ; exit 1; } | |||
nvm use --delete-prefix v0.2.3 || die "Failed to activate v0.2.3" | |||
[ `expr "$PATH" : ".*v0.2.3/.*/bin.*"` != 0 ] || die "PATH not set up properly" | |||
[ `expr "$NODE_PATH" : ".*v0.2.3/.*/lib/node_modules.*"` = 0 ] || die "NODE_PATH should not contain (npm root -g)" | |||
# ^ note: NODE_PATH should not contain `npm root -g` since globals should not be requireable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct as-is, since it’s dealing with the “require” function
@ljharb: dropped |
@PeterDaveHello there's no order that PRs generally need to be merged in; submitting it sooner doesn't guarantee it will be merged first. I'll always handle the rebase if it's needed. |
Okay, just want to prevent rebasings and conflicts. |
Generated by https://github.com/jsoref/spelling
f
; to maintain your repo, please considerfchurn