-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Re-enable WITHOUT_CURL tests #1489
[Tests] Re-enable WITHOUT_CURL tests #1489
Conversation
wow the CI time seems to be doubled ... maybe we should test it another way, it's a little bit sad to see the time been doubled after i tried to reduce the time to half twice 😞 |
The problem should be at every tests with |
Though I think it's nothing to do with nodejs itself, I still manually build nodejs v7.8.0 with/without curl, there is no time difference - with curl:
without curl:
|
|
It might be worth experimenting with the timing of the actual removal of curl - not sure tho, that seems weird. |
can't figure it out, maybe just see it it'll be fixed by its self ... |
To prevent #1487 bug appears again.