[Tests] Add retry on urchin setup which has no built in retry feature #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PeterDaveHello this looks good, but tests are failing |
PeterDaveHello
force-pushed
the
travis-ci-retry
branch
from
7cf3a9b to
cbd3aae
Compare
|
trying another place to put that command |
|
Should be good now? |
Unlike other built in functions like git fetch or apt-get dependencies, manual installations won't have retry by default, enabling retry could help reduce the impact of network issues and furthur prevent getting build error like Job nvm-sh#1956.21: - https://travis-ci.org/creationix/nvm/jobs/212640007 Ref: - https://docs.travis-ci.com/user/common-build-problems/
PeterDaveHello
force-pushed
the
travis-ci-retry
branch
from
cbd3aae to
237c3a7
Compare
ljharb
approved these changes
Mar 22, 2017
| @@ -24,7 +24,7 @@ before_install: | |||
| - if [ -n "${SHELLCHECK-}" ]; then cabal update && cabal install transformers-0.4.3.0 ShellCheck && shellcheck --version ; fi | |||
| - if [ -n "${DOCTOCCHECK-}" ]; then nvm install node && npm install -g doctoc && type doctoc ; fi | |||
| install: | |||
| - (mkdir /tmp/urchin && cd /tmp/urchin && curl -s "$(curl -s https://registry.npmjs.com/urchin | grep -Eo '"tarball":\s*"[^"]+"' | tail -n 1 | awk -F\" '{ print $4 }')" -O && tar -x -f urchin*) | |||
| - (travis_retry mkdir /tmp/urchin && cd /tmp/urchin && curl -s "$(curl -s https://registry.npmjs.com/urchin | grep -Eo '"tarball":\s*"[^"]+"' | tail -n 1 | awk -F\" '{ print $4 }')" -O && tar -x -f urchin*) | |||
There was a problem hiding this comment.
Does this travis_retry just the mkdir? or the entire command?
There was a problem hiding this comment.
I think it'll take the entire command:
https://github.com/travis-ci/travis-build/blob/aa01103e39c521e8b6c4ed2decbae9956ea6f809/lib/travis/build/templates/header.sh#L229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other built in functions like git fetch or apt-get dependencies,
manual installations won't have retry by default, enabling retry could
help reduce the impact of network issues and furthur prevent getting
build error like Job #1956.21:
Ref: