speed up when change directory in zsh#1264
Merged
Merged
Conversation
ljharb
reviewed
Oct 13, 2016
| current=`pwd` | ||
| count=`echo $current | grep -o '/' | wc -l` | ||
| matchStatus='miss' | ||
| while [[ $count -ge 0 ]] |
Member
There was a problem hiding this comment.
This code can get a lot simpler if you use nvm_find_nvmrc which will print out the first .nvmrc it finds - it's the same code nvm uses internally.
Author
There was a problem hiding this comment.
OK, I have updated my code by your suggestion
ljharb
requested changes
Oct 14, 2016
| local nvmrc_path="$(nvm_find_nvmrc)" | ||
|
|
||
| if [ -n "$nvmrc_path" ]; then | ||
| if [ "v$(cat $nvmrc_path)" != "$nodeversion" ]; then |
Member
There was a problem hiding this comment.
this won't work because the .nvmrc file could contain 1 or v1.0 or v1.0.0 or foo (where "foo" is an alias) - you'd need $(nvm version "$(cat "${nvmrc_path}")")
ljharb
approved these changes
Oct 14, 2016
ljharb
left a comment
Member
There was a problem hiding this comment.
LGTM! mind rebasing this down to a commit?
Author
|
@ljharb , thanks for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolve two questions: