fix: replace deprecated LSP client method calls with colon syntax #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeguooooo
force-pushed
the
fix-client-method-deprecations
branch
2 times, most recently
from
57c0a13 to
4fecd20
Compare
Replaces deprecated dot notation with colon notation for LSP client methods: - client.supports_method() → client:supports_method() - client.request() → client:request() - client.request_sync() → client:request_sync() This addresses deprecation warnings in Neovim 0.11+ as documented in :help deprecated.txt Backwards compatible: Colon syntax is just Lua syntactic sugar supported since Neovim 0.5+. No functionality changes, only modernized syntax. Fixes: nvimdev#1543
leeguooooo
force-pushed
the
fix-client-method-deprecations
branch
from
4fecd20 to
62efbee
Compare
|
any news on this? would be nice to get rid of the deprecation warnings every time i boot nvim @glepnir :). the error started showing up for me when I updated nvim to 0.12 dev |
|
Same for me the error started in nightly build -- temp error with nvim.progress and nvim.lspsaga [to be updated ]
vim.deprecate = function() end |
|
turning off deprecations warnings, defeats the entire purpose of running with neovim:master builds. |
kellerben
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes deprecation warnings in Neovim 0.11+ by replacing deprecated LSP client method calls with the new colon syntax.
Changes
client.supports_method()withclient:supports_method()client.request()withclient:request()client.request_sync()withclient:request_sync()Backwards Compatibility ✅
This change is fully backwards compatible and requires no version checks:
client:method()is identical toclient.method(client, ...)- just cleaner syntaxFiles Modified
lua/lspsaga/codeaction/lightbulb.lualua/lspsaga/symbol/head.lualua/lspsaga/symbol/init.lualua/lspsaga/util.lualua/lspsaga/typehierarchy.lualua/lspsaga/codeaction/init.lualua/lspsaga/callhierarchy.lualua/lspsaga/implement/init.luaBackground
In Neovim 0.11+, the LSP client API has deprecated the dot notation for client methods in favor of colon notation. This change maintains the same functionality while using the modern API and eliminates deprecation warnings like:
Test Plan
Closes #1543