feat(lint): add stderr and ignore_exit_code options
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some linters (e.g., cpplint) output to stderr and exit non-zero when
lint issues are found, which guard treats as a failure. This adds two
options to handle such tools:
- `stderr`: capture stderr instead of stdout
- `ignore_exit_code`: don't treat non-zero exit as error
Example usage:
```lua
ft('cpp'):lint({
cmd = 'cpplint',
fname = true,
stderr = true,
ignore_exit_code = true,
parse = ...,
})
```
barrettruth
changed the title
stderr and ignore_exit_code options
Member
|
Hey, thank you for the pr. However, I won't be merging this, see https://github.com/nvimdev/guard.nvim/blob/main/ADVANCED.md |
Contributor
Author
|
Ah. I didn't see that there was a guide. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some linters output to stderr and exit non-zero on lint findings. for example,
cpplintwrites diagnostics to stderr and exits non-zero when it finds style issues - even though the code compiles fine.currently,
guard.nvimtreats this as a failure so i considered adding two options.stderr: capture stderr instead of stdoutignore_exit_code: don't treat non-zero exit as erroralso, i'm about to make a pr to
guard-collectionfor cpplint that depends on this soon (and a bunch of other prs for other formatters/linters, since im swapping fromnone-lsto guard...).