feat: add variant="light|dark" option to override &background #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhCode
force-pushed
the
add-variant-option
branch
2 times, most recently
from
3315fbe
to
74bbc57
Compare
williamhCode
force-pushed
the
add-variant-option
branch
from
74bbc57
to
6d87ada
Compare
That's unavoidable; we can't do anything until we know their choice. Setup actually expects the icons to be populated i.e. refresh_icons has been called: https://github.com/williamhCode/nvim-web-devicons/blob/83238ce4809b4a34282ca8148e26e2d3fbf09ff7/lua/nvim-web-devicons.lua#L397 Suggestion: move the refresh_icons call at 595 to setup. |
alex-courtis
requested changes
Sep 16, 2024
|
Additionally, i moved the refresh to right after setting variant global opt |
alex-courtis
approved these changes
Sep 20, 2024
alex-courtis
changed the title
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the discussion here: #491 (reply in thread)
I have a few questions about the code. Right now,
refresh_icons()is called directly in thenvim-web-devicons.luafile. However, now that I'm adding an option which therefresh_icons()function depends on, should I move the call into thesetup()function? Right now im just callingrefresh_icons()again if the variant option is not "auto", which is a bit inefficient.