nvim-tree colorscheme doesn't update with the rest of the editor

[Hubro]

Description

When setting a colorscheme with :colorscheme ..., nvim-tree doesn't update. It has to be closed and re-opened.

This doesn't seem to happen with some built-in colorschemes I tested, but it happens with some third party themes (I tested nightfox and dayfox.)

I'm not sure if the bug/fault lies with nvim-tree here, but it would be good to know what the problem is so it can be reported and fixed at the right place.

Neovim version

NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

Linux 5.19.13-arch1-1

nvim-tree version

b01e7be

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      "EdenEast/nightfox.nvim",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {}
end

Steps to reproduce

1. Set colorscheme to "nightfox"

   

2. Open NvimTree

3. Set colorscheme to "dayfox"

   

Expected behavior

I would expect the colorscheme of nvim-tree to also update.

Actual behavior

The color scheme of nvim-tree remains, although some colors change subtly, such as the text color.

[Hubro]

Wow, thanks for the quick fix! I tested it and it works 🚀