Restructuring #15
Merged
Restructuring #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2024 01:49
Move the actual code from telescope/_extension folder into the actual plugin folder.
To remove variable shadowing and make the code easier to work with, migrate the local methods into a class and return a callback, which only contains the picker itself.
This was referenced May 21, 2024
Merged
|
While working on a feature to insert links (see PR #16) I drove the refactoring a little further. I was able to reuse most of the code from |
To prepare an upcoming feature, methods from refile_heading are moved into utils to make them reusable. Because all files were touched, the code is also reformatted according to the stylua.conf.
lyz-code
approved these changes
May 21, 2024
|
Thanks @seflue for the contribution, it's really well written <3 I feel unable to maintain the plugin on my own, would you like to become a maintainer? |
|
Sure, actually I would like to contribute as a maintainer of the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to work with the code and add additional functions, I restructured the code according to the recommendations in Telescopes developer guideline.
I also restructured refile_heading.lua a little bit, so it is easier to digest.