feat(api): Allow to insert links through API #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kristijanhusak Please see my PR in Telescope-orgmode as an example, how this change can be used. I actually need this change for that feature. |
kristijanhusak
requested changes
May 21, 2024
| --- Insert a link to a given location at the current cursor position | ||
| --- @param link_location string | ||
| --- @return boolean | ||
| function OrgApi.insert_link(link_location) |
There was a problem hiding this comment.
Let's abstract all this logic in Hyperlinks and then require that one here. I'm trying not to depend on orgmode.api in the core, but vice versa.
There was a problem hiding this comment.
I have to admit, that I just looked at other functions, which had similar calling schemes, but I agree, that it would be cleaner to move them into Hyperlinks.
There was a problem hiding this comment.
I moved the code as you suggested.
added 2 commits
May 21, 2024 23:57
To give plugins like Telescope-orgmode the ability to insert links, the API needs an extension. The refactoring moves some methods from org.mappings into modules, where they should belong anyway, so they can be used from the new api method. The new API method api.insert_link is mostly existing code moved from org.mappings.insert_link, which now just calls api.insert_link.
To have clean module dependencies, insert_link is now a method of Hyperlinks and is exposed over the api but also called from mappings.
SlayerOfTheBad
pushed a commit
to SlayerOfTheBad/orgmode
that referenced
this pull request
Aug 16, 2024
* feat(api): Allow to insert links through API To give plugins like Telescope-orgmode the ability to insert links, the API needs an extension. The refactoring moves some methods from org.mappings into modules, where they should belong anyway, so they can be used from the new api method. The new API method api.insert_link is mostly existing code moved from org.mappings.insert_link, which now just calls api.insert_link. * refactor: move link insertion into Hyperlinks To have clean module dependencies, insert_link is now a method of Hyperlinks and is exposed over the api but also called from mappings. --------- Co-authored-by: Sebastian Flügge <sebastian.fluegge@dnv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To give plugins like Telescope-orgmode the ability to insert links, the API needs an extension.
The refactoring moves some methods from org.mappings into modules, where they should belong anyway, so they can be used from the new api method.
The new API method api.insert_link is mostly existing code moved from org.mappings.insert_link, which now just calls api.insert_link.