fix: todo state in notifications #1005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/orgmode/notifications/init.lua
Outdated
| utils.concat(result, { | ||
| string.format('# %s (%s)', task.category, task.humanized_duration), | ||
| string.format('%s %s %s', string.rep('*', task.level), task.todo, task.title), | ||
| string.format('%s %s %s', string.rep('*', task.level), todo, task.title), |
There was a problem hiding this comment.
No need for if else above. This is enough.
Same thing for below.
Suggested change
| string.format('%s %s %s', string.rep('*', task.level), todo, task.title), | |
| string.format('%s %s %s', string.rep('*', task.level), task.todo or '', task.title), |
Maltimore
force-pushed
the
notifications_fix_nil_todo_state
branch
from
97ffdeb to
32e4d0e
Compare
|
Thanks for your guidance! I've updated the PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the TODO state of a note was nothing, it showed as
nilin the notification.edit: the notificaionts-popup notifications don't work for me, so I only tested the cron notifications via notify-send.
Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.