Skip to content

Conversation

@nhat-vo
Copy link
Collaborator

@nhat-vo nhat-vo commented Feb 21, 2023

Implement #696:

  • Added a command close_all_subnodes that behaves analogously to close_node but also collapses all nodes in the subtree.
  • Also changed renderer.get_expanded_nodes() to search for expanded subnodes of already collapsed nodes (this might make close_all_nodes slower, so I'm not sure if it should be changed or not)

@nhat-vo nhat-vo requested review from cseickel and miversen33 and removed request for miversen33 February 21, 2023 15:14
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cseickel cseickel merged commit 08d7cc9 into nvim-neo-tree:main Feb 21, 2023
@farzadmf
Copy link

Just wondering: given that the default branch is v2.x, shouldn't this PR have been merged to that branch instead of main? 🤔

@cseickel
Copy link
Contributor

Just wondering: given that the default branch is v2.x, shouldn't this PR have been merged to that branch instead of main? 🤔

No, v2.x is the stable release branch. Everything merges to main first for testing by our more adventurous users before graduating to v2.x. I'll be releasing tomorrow morning.

@farzadmf
Copy link

Ah, OK, cool, thank you for letting me know. Will test it out once it's released then

@nhat-vo nhat-vo deleted the 696-close-all-subnodes branch May 19, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants