fix: cancel close_if_last_window if there is an unnamed modified buffer, fixes #605 #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 50.48% 50.26% -0.23%
==========================================
Files 47 47
Lines 6103 6122 +19
==========================================
- Hits 3081 3077 -4
- Misses 3022 3045 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cseickel
force-pushed
the
fix-last-win-close-with-unsaved-no-name
branch
from
0dddd65 to
1d8cc3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situation described in #605
The new strategy is to detect if there is an unnamed modified buffer, and if there is, it will open it and show a warning message.