Skip to content

fix(log): remove file attribute on close #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

fix(log): remove file attribute on close #1885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0356640
remove file attr on close
pynappo Oct 6, 2025
49695ed
cleanup
pynappo Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions lua/neo-tree/log.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ log_maker.new = function(config)
-- Assume that subsequent writes will fail too, so stop logging to file.
log.use_file(false, true)
log.error("Error writing to log:", writeerr)
log.file:close()
end

local curtime = os.time()
Expand Down Expand Up @@ -199,10 +198,7 @@ log_maker.new = function(config)
-- Return early if we're below the config.level
-- Ignore this if vim is exiting
if vim.v.dying > 0 or vim.v.exiting ~= vim.NIL then
if log.file then
config.use_file = false
log.file:close()
end
log.use_file(false, true)
end

local msg = message_maker(...)
Expand Down Expand Up @@ -313,6 +309,10 @@ log_maker.new = function(config)
log.use_file = function(file, quiet)
if file == false then
config.use_file = false
if log.file then
log.file:close()
end
log.file = nil
if not quiet then
log.info("Logging to file disabled")
end
Expand Down Expand Up @@ -374,9 +374,7 @@ log_maker.new = function(config)
else
errmsg = "assertion failed!"
end
if config.use_file then
log_to_file("ERROR", errmsg)
end
log.error(errmsg)
return assert(v, errmsg)
end

Expand Down
Loading