-
Notifications
You must be signed in to change notification settings - Fork 271
add NeoTreeFloatTitle highlight group #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NeoTreeFloatTitle highlight group #169
Conversation
|
This looks good, I'll just try it out later and I'll merge if there are no issues. |
|
The problem with this is that I don't think the TitleBar highlight group looks good with a normal border. I tried using the FloatBorder group for the title and that's better but still not great. I think the right thing to do is to add another highlight group which uses the same background as float border but with the Normal foreground. |
|
I just added a commit to show you what I mean, what do you think about that? Docs would still need to be updated. |
|
I didn't even check the NC style because I didn't expect it to be affected. If you back out the changes you made to that branch then it should work out correctly. I'd like to keep the added highlight group because I think it's something that others would want to be able to change. I know I personally don't like the way it looks when the title text is the same color as the border. We can, however, make the default for that new group just be linked to the FloatBorder group so the default look is still what you are looking for. |
Yeah, that's nice to have. I have restored this in the latest commit and kept the defaults you set initially as they seem perfectly fine to me. I'm more than happy to be able to set my own colors in my personal configuration. I have also added documentation for the new highlight group and have grouped the three groups together. |
cseickel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!






This fixes the issue described in #35. I cleaned everything up and updated the documentation accordingly.
If there's something missing please let me know!
Best regards!