[Bug] neotree errors when a git repo contains any executable/binary file (.o, .exe, .elf, .a, etc)

[terrifictable]

Issue

When having some kind of executable/binary (.o, .exe, .elf, .a, etc) file in some directory, trying to open/expand that directory in NeoTree results in the below error (screenshot)

How to reproduce

1. Compile any program (i used C/C++)
2. open the folder the compiled file was put into
3. the below error appears

Environment

OS: Windows x64
NeoVim (v0.9.0-dev-964+g1539f7136) installed trough chocolatey
Im using packer.nvim for packages
neo-tree config: default

packer neo-tree setup:

use { "nvim-neo-tree/neo-tree.nvim", 
  branch = "v2.x",	
  requires = {
    "nvim-lua/plenary.nvim",
    "nvim-tree/nvim-web-devicons",
    "MunifTanjim/nui.nvim",
  },
}

[terrifictable]

It seems to be something with git, if i copy the folder and remove the .git folder, it works fine without error
but as soon as i initialize a git repo in that folder it starts throwing this error

[cseickel]

I can't recreate the issue on my computer using linux and copying the find executable to a git repo. I don't have a Windows computer so I can't test it there.

Based on the error message though, I would think that it is actually a problem with UTF handling in the filename. Can you confirm that the file or folder in question has some non-ascii characters? Can you give me the full path of a file that causes this error?

[terrifictable]

the full path is: F:\programming\2023\c_cpp\6502\bin\main.exe (thats the output file, the root is at c_cpp\6502\)

the error occours when having (almost) any executable
in the screenshot it was the output of this makefile (from https://github.com/TerrificTable/6502-Emulator):

CXX 	 	:= g++
CXXFLAGS 	:= -std=c++20 -g -Wall -Wextra -Werror


OUT := bin/main.exe

SRC := $(wildcard src/**/*.cpp) $(wildcard src/*.cpp)
OBJ := $(patsubst src/%.cpp,bin/%.o,$(SRC))

all: $(OBJ)
	@mkdir -p $(dir $(OUT))
	$(CXX) $(CXXFLAGS) -o $(OUT) $(OBJ)
	./$(OUT)

bin/%.o: src/%.cpp
	@mkdir -p $(@D)
	$(CXX) $(CXXFLAGS) -c $< -o $@


clean:
	rm -r $(dir $(OUT))

these are the files (using nvim-tree):

[cseickel]

I think my last commit will fix this, can you try again using the main branch?

[terrifictable]

Neo-tree opens, but now im getting this error when hiding/unhiding files, changing wording directory, reloading and some other things

the commit seems to have fixed the git error

[cseickel]

I had an error there. Can you update and try again?

[terrifictable]

it works without any errors now, but well... some files/folders are/look like they're hidden (or were hidden) even tho they dont start with a . nor are their names in my hidden files configuration


(only .git should be hidden, .gitignore and .gitmodules should be gray because they're in my hidden files configuration thingy)

        filtered_items = {
            visible = false, -- when true, they will just be displayed differently than normal items
            hide_dotfiles = true,
            hide_gitignored = true,
            hide_hidden = true, -- only works on Windows for hidden files/directories
            hide_by_name = {
                "node_modules"
            },
            hide_by_pattern = { -- uses glob style patterns
            },
            always_show = { -- remains visible even if other settings would normally hide it
                ".gitignore",
                ".gitmodules",
            },
            never_show = { -- remains hidden even if visible is toggled to true, this overrides always_show
            },
            never_show_by_pattern = { -- uses glob style patterns
            },
        },

[cseickel]

Those files are gitignored, you can change:

hide_gitignored = true,

if you want them to show normal.