Handle files in .git/info/exclude like files .gitignore

[ghillb]

Currently neo-tree doesn't include files in .git/info/exclude if hide_gitignored=true.

Proposal:
neo-tree should respect .git/info/exclude, like nvim-tree does.

[cseickel]

This is the first I have heard about this feature, it's amazing how much you learn when you respond to issues in an open source project!

That being said, I think nvim-tree showing files that were in the exclude list was a bug. If it's in the exclude list, isn't that just a personal .gitgnore, meaning that the files mentioned there should be ignored by git? If my understanding is correct, then they should be hidden when hide_gitignored=true.

[ghillb]

You are correct that's what it is and the way it should be handled, but currently is not.
Maybe my wording was confusing. Files in .git/info/exclude are displayed in neo-tree, when hide_gitignored=true.

[cseickel]

Maybe my wording was confusing. Files in .git/info/exclude are displayed in neo-tree, when hide_gitignored=true.

Sorry, that's on me, I'm not sure why I misunderstood that. I'll give it a try later and figure out what's wrong

[cseickel]

I just tested it out and it works for me. In the screenshot below I toggle hidden files as visible, but you can tell that test.lua is ignored because of the grey highlight and the ignored symbol next to it:

Can you confirm from the terminal that the files you are expecting to be hidden are actually considered ignored by git? Can you also share your config?

[ghillb]

I just discovered that this problem only occurs if the file in the .gitignore or .git/info.exclude is also a dotfile and hide_dotfiles=false:

Here are my filter settings:

  filtered_items = {
    visible = true,
    hide_dotfiles = false,
    hide_gitignored = true,
    hide_by_name = {
      ".git",
    },
    never_show = {
      ".git",
    },
  },

My expectation was that non-hidden dotfiles would be grayed out with ignore symbol (∅) when they are in .gitignore & .git/info/exclude.

[cseickel]

That makes total sense now. I have a cascading if/elseif statement for this and the gitignored check is the last one in that list. This is an easy fix that I'll get out soon.

[cseickel]

If you want to try out main, this should be fixed in that branch.

[ghillb]

I checked out the main branch and now I get this message, when opening neo-tree:

[cseickel]

That's a new error message for me, I'm surprised to see a path ending in ... Could you walk me through all the steps you took to get to that error, starting with the nvim command used to open nvim?

[ghillb]

It is not much:

1. cd into repo cd ~/code/tmp/neo-tree-test/
2. open file in repo: nvim .gitignore
3. open neo-tree: :Neotree toggle reveal

I re-checked and the error is not present in the 2.x branch.

Edit:
After the latest commits on main, the error is now gone, but the behavior regarding dotfiles is unchanged (screenshot).