Support trash instead of delete

[mo8it]

Thanks for the awesome plugin!

Adding support for trash instead of rm would be awesome!
Nvim-Tree does this with the D shortcut.

[cseickel]

This would be a simple one for a custom command. Take a look at :h neo-tree-custom-commands

Something like this should work (from memory, not tested):

   require("neo-tree").setup({
     filesystem = {
       window = {
         mappings = {
           ["D"] = functions(state)
             local node = state.tree:get_node()
             local path = node:get_id()
             vim.fn.system("trash " .. vim.fn.fnameescape(path))
           end
         }
       }
     }
   })

[mo8it]

Thanks for your answer, I did go with this:

require("neo-tree").setup({
	filesystem = {
		commands = {
			-- Override delete to use trash instead of rm
			delete = function(state)
				local path = state.tree:get_node().path
				vim.fn.system({ "trash", vim.fn.fnameescape(path) })
			end,
		},
	},
})

It did work and the docs in :h neo-tree-custom-commands were helpful, but now I have the problem that it does not refresh after sending to trash. I did take a look at the code, it does not seem very easy to try to copy everything is done when deleting. No conformation, no output, not sure about symlinks and directories. So, if would implement it, I would really appreciate it ^^

In the mean time: Can you please tell me how to refresh the tree after the operation is done?

Thank you a lot for the quick rely!

[cseickel]

You can use require("neo-tree.sources.manager").refresh(state.name) to refresh:

require("neo-tree").setup({
	filesystem = {
		commands = {
			-- Override delete to use trash instead of rm
			delete = function(state)
				local path = state.tree:get_node().path
				vim.fn.system({ "trash", vim.fn.fnameescape(path) })
                                require("neo-tree.sources.manager").refresh(state.name)
			end,
		},
	},
})

[cseickel]

Looking at the code now, there is some extra niceties happening that is worth having. I will leave this up as an enhancement, but since I don't use trash I'm not the best person to implement it. Hopefully someone else will pick it up.

[mo8it]

Refreshing did work. Thank you!

[ttytm]

To extend #202 (comment) the example below adds a confirmation dialog.

What's still open is using the trash when deleting a range of files.

But usually git should lull one into safety without the need for a trash.

delete = function(state)
	local inputs = require "neo-tree.ui.inputs"
	local path = state.tree:get_node().path
	local msg = "Are you sure you want to delete " .. path
	inputs.confirm(msg, function(confirmed)
		if not confirmed then return end

		vim.fn.system { "trash", vim.fn.fnameescape(path) }
		require("neo-tree.sources.manager").refresh(state.name)
	end)
end,

[riodelphino]

To work with multi selected nodes (in Visual mode), I also extended tobealive's code to below.

-- over write default 'delete' command to 'trash'.
delete = function(state)
	local inputs = require("neo-tree.ui.inputs")
	local path = state.tree:get_node().path
	local msg = "Are you sure you want to trash " .. path
	inputs.confirm(msg, function(confirmed)
		if not confirmed then return end

		vim.fn.system { "trash", vim.fn.fnameescape(path) }
		require("neo-tree.sources.manager").refresh(state.name)
	end)
end,

-- over write default 'delete_visual' command to 'trash' x n.
delete_visual = function(state, selected_nodes)
	local inputs = require("neo-tree.ui.inputs")

	-- get table items count
	function GetTableLen(tbl)
		local len = 0
		for n in pairs(tbl) do
			len = len + 1
		end
		return len
	end

	local count = GetTableLen(selected_nodes)
	local msg = "Are you sure you want to trash " .. count .. " files ?"
	inputs.confirm(msg, function(confirmed)
		if not confirmed then return end
		for _, node in ipairs(selected_nodes) do
			vim.fn.system { "trash", vim.fn.fnameescape(node.path) }
		end
		require("neo-tree.sources.manager").refresh(state.name)
	end)
end,

nvim's reboot is required for that 'refresh' command to work.

Thanks for all your advices.

[sxyazi]

@riodelphino Thanks for sharing, helped me a lot.
There is a built-in vim.tbl_count function, or #selected_nodes that can be used to simplify the GetTableLen. 😸

[amitlevy21]

I just deleted 18 hours of work by mistake.
PLEASE, make this the default behavior

Its not reasonable to delete files forever with rm command when working with an editor