How to make MiniSessions.restart() not open empty buffer with directory name

[andradei]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.sessions

Question

1. Open a directory nvim ~/.config/nvim
2. Open a few buffers
3. Run MiniSessions.restart()
4. Buffers are restored and an extra buffer called nvim is also created

This buffer matches the directory I opened neovim with in step 1.

I also have this auto command which affects the startup process:

vim.api.nvim_create_autocmd('VimEnter', {
	desc = '  Open file picker when passing a directory: `nvim <dir>`',
	once = true, -- one shot
	nested = true, -- handle other autocmds, like FileType
	callback = function(data)
		local is_dir = vim.fn.isdirectory(data.file) == 1
		if is_dir then
			vim.cmd.cd(data.file)
			MiniPick.builtin.files()
			-- Delete the empty buffer neovim creates when passing a directory.
			vim.api.nvim_buf_delete(data.buf, { force = true })
		end
	end,
})

How do I make MiniSessions.restart() also delete that empty buffer with directory name?

[drowning-cat]

What do you use to display buffers (for example, bufferline.nvim or mini.tabline)? I assume that opening Neovim in a directory also opens the default file manager (netrw) as a buffer named after that directory. So the question is: why is that a problem, or more importantly, where is it being displayed?

[echasnovski]

I think this is a somewhat unintended behavior of MiniSessions.restart(). The reason is that written session always preserves arguments.

The more concise way to reproduce this would be:

• nvim -- file-a
• :bwipeout
• :edit file-b.
• :lua MiniSessions.restart(). It now shows both file-a and file-b.

I'll take a look.

[echasnovski]

Yeah, it seems to be a combination of two things:

• The :mksession always preserves argument list. It can be fixed on 'mini.sessions' side.
• The :restart command always restarts respecting arguments passed before --, like nvim ~/.config/nvim. This is documented and can not be fixed on 'mini.sessions' side (the responsible v:argf variable is read-only). This behavior will probably be revised.

So @andradei, if you want to not have this behavior, my best suggestions are:

• Use nvim -- ~/.config/nvim to open directories.

• Append the autocommand from the original comment with vim.cmd('%argdelete'). This will clear the argument list on top of deleting the buffer for the opened directory. Not needed anymore since it is cleared before restarting (if there is no active session).

  I'll take a closer look if it is a good idea to add this type of "clear arglist" functionality to MiniSessions.restart() itself.

[andradei]

Thanks for looking into this. Your 2 suggestions worked perfectly.
mini.sessions could have a setup/config option to not preserve the arglist. Keeping current neovim behavior as the default.

[echasnovski]

mini.sessions could have a setup/config option to not preserve the arglist. Keeping current neovim behavior as the default.

My current thinking is that clearing arglist is okay unconditionally if there is no active session. The reasoning is described in 9d5a26f. But I'll need to sleep on this.

[echasnovski]

@andradei, the %argdelete part is not needed anymore for this use case. Only start Neovim as nvim -- dir and not nvim dir (but hopefully soon-ish this won't be needed either, as Neovim upstream will adjust the restart behavior). I updated the accepted answer.

[abeldekat]

@andradei, I noticed that the picker also activates on restart. I could imagine that this is not needed when restarting with mini.sessions.

EDIT: Removed incorrect lua example...
EDIT: Example was correct, but only works with MiniSessions.restart, not with a plain :restart...

Using nvim ~/.config/nvim still seems to work if the unwanted buffer is deleted inside UIEnter:

require('mini.sessions').setup()
require('mini.pick').setup()

local directory_argument = nil
vim.api.nvim_create_autocmd('VimEnter', {
  desc = '  Open file picker when passing a directory: `nvim <dir>`',
  once = true, -- one shot
  nested = true, -- handle other autocmds, like FileType
  callback = function(data)
    local is_dir = vim.fn.isdirectory(data.file) == 1
    if is_dir then
      directory_argument = data.file
      vim.cmd.cd(directory_argument)
      MiniPick.builtin.files()
    end
  end,
})

vim.api.nvim_create_autocmd('UIEnter', {
  desc = 'Delete buffer created when passing a directory: `nvim <dir>`',
  once = true,
  callback = function()
    if not directory_argument then return end

    for _, buf in ipairs(vim.api.nvim_list_bufs()) do
      if vim.api.nvim_buf_get_name(buf) == directory_argument then vim.api.nvim_buf_delete(buf, { force = true }) end
    end
  end,
})

[echasnovski]

I noticed that the picker also activates on restart. I could imagine that this is not needed when restarting with mini.sessions.

After applying the :%argdelete from the answer, it activates only if the start was via nvim ~/.config/nvim and not nvim -- ~/.config/nvim~, right?

[abeldekat]

Yes, indeed. I was investigating a way to avoid having to use the --....

[echasnovski]

Yes, indeed. I was investigating a way to avoid having to use the --....

Ah, okay then. That's valuable. I sort of think it is okay to always prefer nvim -- file as it is less ambiguous, but I see how not everybody can get used to this.

[andradei]

but I see how not everybody can get used to this.

Count me in that group. Other editors don't need -- either. Excited for future improvements to :restart.

[abeldekat]

@echasnovski,

Would it be an idea to add a variant of the g:startreason suggested here to mini.sessions restart? In that way, OP could choose to not open the picker on restart...

[echasnovski]

I'd rather not add something home grown as there are 1) reasonable workaround (use nvim -- dir and not nvim dir); and 2) the current behavior of restarting with all file arguments is planned to be removed.

[abeldekat]

Perhaps more generic: Allow the user to pass a list of commands, to be executed during restart...

[echasnovski]

That's an interesting one. Sounds reasonable, but I'd wait for a more complicated use case that could not be solved without it.

The whole MiniSessions.restart is an "emergency measure" until :restart can support preserving the layout. And that is planned, only needs an implementation.