Skip to content

Conversation

dam9000
Copy link
Contributor

@dam9000 dam9000 commented Mar 31, 2024

My last commit needs an additional fix:

The recent addition of the keys field in the lazy plugin spec for conform has turned the plugin to be lazy loaded on the configured keymap. This inadvertently broke the default "format on save" behaviour. Setting the lazy flag explicitly to false restores the original behaviour. (and keeps the keymap working as well)

I apologize for not noticing this before, my testing was not thorough enough.

The recent addition of the keys field in the lazy plugin spec
for conform has turned the plugin to be lazy loaded on the
configured keymap. This inadvertently broke the default "format on save"
behaviour. Setting the lazy flag explicitly to false restores the
original behaviour.
@feoh feoh merged commit d605b84 into nvim-lua:master Apr 1, 2024
@dam9000 dam9000 deleted the pr-conform-non-lazy branch April 1, 2024 07:42
flearc pushed a commit to flearc/kickstart.nvim that referenced this pull request Apr 9, 2024
Peter-McKinney pushed a commit to Peter-McKinney/pete.nvim that referenced this pull request Apr 9, 2024
cbat98 pushed a commit to cbat98/kickstart.nvim that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants