Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add content type to preview server #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kantord
Copy link

@kantord kantord commented Jan 9, 2024

Summary/ Motivation (TLDR;)

This allows jest-preview to be used in GitHub Codespaces and probably fixes other problems.

The preview server was not setting the content type header in the response.
Somehow this does not cause any problems when running in localhost, but it
seems like it prevents the preview from being rendered in GitHub Codespaces
environments, becuase the page gets rendered as a text file instead of html

Related issues

Fixes

  • fix content type header in the preview server

This allows `jest-preview` to be used in GitHub Codespaces
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for jest-preview-library canceled.

Name Link
🔨 Latest commit 6e4752d
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-library/deploys/659d80dce6a71d0008155bea

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for jest-preview-chinese canceled.

Name Link
🔨 Latest commit 6e4752d
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-chinese/deploys/659d80dcf8bac10008c7f722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant